On 13 February 2018 at 23:00, Kyriazis, George <[email protected]> wrote: > >> On Feb 13, 2018, at 4:54 PM, Dylan Baker <[email protected]> wrote: >> >> Quoting Andres Gomez (2018-02-13 14:42:57) >> [snip] >>> >>> -if with_amd_vk or with_gallium_radeonsi >>> +if with_amd_vk or with_gallium_radeonsi or with_gallium_swr >>> _llvm_version = '>= 4.0.0' >>> -elif with_gallium_opencl or with_gallium_swr or with_gallium_r600 >>> +elif with_gallium_opencl or with_gallium_r600 >> >> It's really up to the SWR team what they want to do here, but Meson doesn't >> generate the headers as part of building a dist tarball, it generates them at >> build time whether in git or in a tarball. And doesn't use the ones >> generated by >> autotools, so it *should* be possible to leave this as 3.9.0 if they like. >> > It makes sense to be consistent across the board. Once we switch to 4.0.0, > it could be confusing to have some aspects of the build still be doable with > pre-4.0.0 llvm. > Consistency is fairly important indeed. Thanks George. Seems like all but one LLVM_VERSION* funks are now dead code.
Will send a fixup in a second. Thanks for bringing this up Andres. Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
