WF2 doesn't seem to like this, but it's good overall, so the patch is:

Reviewed-by: Samuel Pitoiset <>

On 03/06/2018 04:48 AM, Timothy Arceri wrote:
This reverts commit 2d36efdb7f18f061c519dbb93f6058bf161aad33.

This raised limit turns out to harmful for more complex shaders,
it causes excessive spilling in some Bioshock Infinite shaders.

The fps for the ssao demo on radv remains unchanged when reverting

Cc: Dave Airlie <>
  src/compiler/nir/nir_opt_loop_unroll.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/compiler/nir/nir_opt_loop_unroll.c 
index dae5bfc902..79d04f978b 100644
--- a/src/compiler/nir/nir_opt_loop_unroll.c
+++ b/src/compiler/nir/nir_opt_loop_unroll.c
@@ -33,10 +33,8 @@
   * to give about the same results. Around 5 instructions per node.  But some
   * loops that would unroll with GLSL IR fail to unroll if we set this to 25 so
   * we set it to 26.
- * This was bumped to 96 because it unrolled more loops with a positive
- * effect (vulkan ssao demo).
/* Prepare this loop for unrolling by first converting to lcssa and then
   * converting the phis from the loops first block and the block that follows

mesa-dev mailing list

Reply via email to