On 02/16/2012 06:04 PM, Ian Romanick wrote:
On 02/16/2012 04:11 PM, Anuj Phogat wrote:
As suggested by Brian, for a 1D texture array, the border only
applies to the
width. For a 2D texture array the border applies to the width and
height but
not the depth. This was not handled correctly
_mesa_init_teximage_fields().
Note: This is a candidate for stable branches
Signed-off-by: Anuj Phogat<anuj.pho...@gmail.com>
---
Sorry for not considering all the cases in my previous patch. Let me
know
if i have still missed anything.
It looks like everything is here, but I think we need some piglit
tests. I would at least like to see a couple tests that would have
failed with one or more of the previous patches. I think the right
thing is to try create a texture with (and without) border for each
possible target. Then query the dimensions and border size and test
against the expected values.
Brian, does that sound like it would catch the issues you raised in
the previous versions of the patch?
A piglit test like you describe would be great. Though, I have a
feeling that there's more issues related to texture arrays and borders
than just _mesa_init_teximage_fields().
As long as there's no regressions though, this would be good step forward.
-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
