Hi Dave, On Tuesday, 15 May 2018 07:44:44 CEST Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > Some drivers (virgl) don't support GL4.4 or GLES3.1 yet, > so never fill in this const.
May be I should take care of all of these type of asserts, also the ones with MaxVertexAttribRelativeOffset and care for not checking them when the extension version is unavailable or checking against the OpenGL spec guaranteed minimum values for both constants instead of the actual ones. ... means, there are more asserts of this kind. Well, alternatively since you probably aim for supporting GL4.4 at one point, you could alternatively set the constant already? AFAICT the PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE is only used to set the constant and does not imply anything beyond. Anyhow, if it just bothers now ... Reviewed-by: Mathias Fröhlich <mathias.froehl...@web.de> best Mathias > > Signed-off-by: Dave Airlie <airl...@redhat.com> > --- > src/mesa/vbo/vbo_exec_draw.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c > index 31d77002257..9f40e954224 100644 > --- a/src/mesa/vbo/vbo_exec_draw.c > +++ b/src/mesa/vbo/vbo_exec_draw.c > @@ -201,7 +201,6 @@ vbo_exec_bind_arrays(struct gl_context *ctx) > > /* Bind the buffer object */ > const GLuint stride = exec->vtx.vertex_size*sizeof(GLfloat); > - assert(stride <= ctx->Const.MaxVertexAttribStride); > _mesa_bind_vertex_buffer(ctx, vao, 0, exec->vtx.bufferobj, buffer_offset, > stride, false); > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
