On 15 May 2018 at 16:31, Mathias Fröhlich <mathias.froehl...@gmx.net> wrote: > Hi Dave, > > On Tuesday, 15 May 2018 07:44:44 CEST Dave Airlie wrote: >> From: Dave Airlie <airl...@redhat.com> >> >> Some drivers (virgl) don't support GL4.4 or GLES3.1 yet, >> so never fill in this const. > > May be I should take care of all of these type of asserts, also the ones > with MaxVertexAttribRelativeOffset and care for not checking them > when the extension version is unavailable or checking against the OpenGL > spec guaranteed minimum values for both constants instead of the actual ones. > ... means, there are more asserts of this kind. > > Well, alternatively since you probably aim for supporting GL4.4 at one point, > you > could alternatively set the constant already? AFAICT the > PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE is only used to set the > constant and does not imply anything beyond.
Well it's not just virgl, won't this break things like r300 and i915? Dave. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
