On Wed, Dec 12, 2018 at 2:42 PM Marek Olšák <mar...@gmail.com> wrote:

> Most assertions and checks are enabled, because NDEBUG is not defined, but
> DEBUG is not defined either, which is a Mesa-specific definition.
>
> The default debug build for autotools is debugoptimized (-g -O2 -DDEBUG).
> meson changed that behavior by removing -DDEBUG. Autotools doesn't have
> what meson calls "debug", which indicates that most people don't want to
> use "debug" much. People who wanted to -O0 had to set CFLAGS. Now people
> who want the autotools debug build have to add -DDEBUG into CFLAGS.
>

For whatever it's worth, I never do a debug build with either build system
without throwing in -O0 because otherwise the symbols are nearly useless.


> On top of that, I discovered a 3rd issue with meson:
> * meson --reconfigure doesn't re-run llvm-config.
>
> Marek
>
> On Wed, Dec 12, 2018 at 3:13 PM Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
> wrote:
>
>> On Wed, Dec 12, 2018 at 8:59 PM Marek Olšák <mar...@gmail.com> wrote:
>> >
>> > There are 2 issues with meson:
>> > * -DDEBUG is not present in debugoptimized builds.
>>
>> Do people expect -DDEBUG for debugoptimized? I would think that debug
>> optimized would be an optimized build with debug symbols, but not
>> expensive checks & asserts, which would match the current
>> debugoptimized build?
>>
>> > * meson ignores CFLAGS with --reconfigure, for example:
>> CFLAGS="-DDEBUG" meson --reconfigure ... doesn't update CFLAGS.
>> >
>> > Marek
>> >
>> > On Mon, Dec 10, 2018 at 6:11 PM Dylan Baker <dy...@pnwbakers.com>
>> wrote:
>> >>
>> >> Meson 0.49.0 has been out for a couple of days now, and I'd like to
>> make the
>> >> final call for autotools. My patch is so massive that it's a huge pain
>> to send
>> >> to the list, the latest versions is here:
>> >> https://gitlab.freedesktop.org/dbaker/mesa/commits/delete-autotools
>> >>
>> >> Dylan
>> >> _______________________________________________
>> >> mesa-dev mailing list
>> >> mesa-dev@lists.freedesktop.org
>> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>> >
>> > _______________________________________________
>> > mesa-dev mailing list
>> > mesa-dev@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to