On February 5, 2019 20:56:25 Alyssa Rosenzweig <aly...@rosenzweig.io> wrote:

@@ -39,7 +39,7 @@ files_panfrost = files(
'pan_blending.c',
'pan_blend_shaders.c',
'pan_wallpaper.c',
-  'pan_pretty_print.c'
+  'pan_pretty_print.c',
)

inc_panfrost = [

This hunk seems unrelated...

..Oops, although looking at other drivers' meson.builds, it's reasonable
to have the comma there anyway for future proof, no?

I like to keep a trailing comma at the end of lists when the language allows it. It means that a future addition to the end of the list only has + lines and not a -/+ pair to add a comma.

--Jason


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to