oh, also add a Fixes tag please.
On Fri, Mar 8, 2019 at 2:50 PM Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: > > I actually think it is partially right, but lets indeed revert for now > > Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> > > On Fri, Mar 8, 2019 at 2:48 PM Samuel Pitoiset > <samuel.pitoi...@gmail.com> wrote: > > > > This changes is actually wrong because we have to sync > > before doing image layout transitions. > > > > This fixes rendering issues in Batman, Path of Exile and > > probably more titles. > > > > This reverts commit 76c17cfd8da017ebd19be33ba6cef888957a6758. > > > > Cc: 19.0 <mesa-sta...@lists.freedesktop.org> > > Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> > > --- > > src/amd/vulkan/radv_cmd_buffer.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > > b/src/amd/vulkan/radv_cmd_buffer.c > > index 5b66930d137..d8aceb8b082 100644 > > --- a/src/amd/vulkan/radv_cmd_buffer.c > > +++ b/src/amd/vulkan/radv_cmd_buffer.c > > @@ -4395,10 +4395,10 @@ void radv_CmdEndRenderPass( > > { > > RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer); > > > > - radv_cmd_buffer_end_subpass(cmd_buffer); > > - > > radv_subpass_barrier(cmd_buffer, > > &cmd_buffer->state.pass->end_barrier); > > > > + radv_cmd_buffer_end_subpass(cmd_buffer); > > + > > vk_free(&cmd_buffer->pool->alloc, cmd_buffer->state.attachments); > > > > cmd_buffer->state.pass = NULL; > > -- > > 2.21.0 > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev