On 08/24/2012 02:46 PM, Eric Anholt wrote:
Ian Romanick <[email protected]> writes:case GL_RED: case GL_R8: + return ctx->API != API_OPENGLES && ctx->Extensions.ARB_texture_rg + ? GL_RED : 0;R8 should have the gles3 support case here.case GL_R16: - return ctx->Extensions.ARB_texture_rg ? GL_RED : 0; + return _mesa_is_desktop_gl(ctx) && ctx->Extensions.ARB_texture_rg + ? GL_RED : 0; case GL_RG: case GL_RG8: + return ctx->API != API_OPENGLES && ctx->Extensions.ARB_texture_rg + ? GL_RG : 0;RG8 should have the gles3 support case here.
We get RG and friends in API_OPEGNES2 because of GL_EXT_texture_rg. Only API_OPENGLES loses.
case GL_RGB10_A2UI: - return ctx->Extensions.ARB_texture_rgb10_a2ui ? GL_RGBA : 0; + return _mesa_is_desktop_gl(ctx) && + ctx->Extensions.ARB_texture_rgb10_a2ui ? GL_RGBA : 0;rgb10_a2ui is listed in gles3 spec, page 128. I think it should be included here.
You are correct. I'll fix that.
Other than the issues mentioned, the series is Reviewed-by: Eric Anholt <[email protected]>
_______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
