On 5 November 2013 16:21, Eric Anholt <e...@anholt.net> wrote: > In the SIMD16 spilling changes, I replaced a "1" in the spill path with > "mlen", but obviously it wasn't mlen before because spills have the g0 > header along with the payload. The interface I was trying to use was > asking for how many physical regs we're writing, so we're looking for "1" > or "2". > > I'm guessing this actually passed piglit because the high 8 bits of the > execution mask in SIMD8 mode are all 0s. >
Reviewed-by: Paul Berry <stereotype...@gmail.com> > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > index 63ac530..83917f5 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > @@ -757,7 +757,7 @@ fs_generator::generate_scratch_write(fs_inst *inst, > struct brw_reg src) > retype(brw_message_reg(inst->base_mrf + 1), > BRW_REGISTER_TYPE_UD), > retype(src, BRW_REGISTER_TYPE_UD)); > brw_oword_block_write_scratch(p, brw_message_reg(inst->base_mrf), > - inst->mlen, inst->offset); > + dispatch_width / 8, inst->offset); > } > > void > -- > 1.8.4.rc3 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev