On Fri, Dec 5, 2014 at 5:23 PM, Ben Widawsky <b...@bwidawsk.net> wrote: > On Fri, Dec 05, 2014 at 05:08:40PM -0800, Matt Turner wrote: >> diff --git a/src/mesa/drivers/dri/i965/intel_asm_annotation.c >> b/src/mesa/drivers/dri/i965/intel_asm_annotation.c >> index 37ad090..ac12655 100644 >> --- a/src/mesa/drivers/dri/i965/intel_asm_annotation.c >> +++ b/src/mesa/drivers/dri/i965/intel_asm_annotation.c >> @@ -109,7 +109,7 @@ void annotate(struct brw_context *brw, >> >> struct annotation *ann = &annotation->ann[annotation->ann_count++]; >> ann->offset = offset; >> - if ((INTEL_DEBUG & DEBUG_NO_ANNOTATION) == 0) { >> + if ((INTEL_DEBUG & DEBUG_ANNOTATION) != 0) { > > if (INTEL_DEBUG & DEBUG_ANNOTATION)
I really don't like the implicit int -> bool conversion (and I hate the explicit conversion with !! even more). _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev