[EMAIL PROTECTED] wrote:
>
> Hi Folks,
>
> I committed the following
> src/descrip.mms : Updates for the new source files
> src/enums.c : Included <string.h> to avoid warnings on strcmp.
> renamed the variable index to index1 to avoid conflicts
> with <string.h>
> src/FX/fxcva.c : Added the "#if defined(FX)" stuff like all other FX
> sources
>
>
> I did not commit the folowing patch since I'm not realy sure if COPY_3V is
> the correct macro to use. (should it be COPY_3FV???).
> COPY_4FV is wrong here since it writes outside the array bound.
>
> *** cva.c Thu Apr 1 10:23:41 1999
> --- cva.c;1 Thu Apr 1 07:15:39 1999
> ***************
> *** 76,82 ****
> } else {
> for (i = 0 ; i < nr ; i++) {
> CONST GLubyte *f = (GLubyte *)from + elt[i] * stride;
> ! COPY_3V( to[i], (GLfloat *)f );
> }
> }
>
> --- 76,82 ----
> } else {
> for (i = 0 ; i < nr ; i++) {
> CONST GLubyte *f = (GLubyte *)from + elt[i] * stride;
> ! COPY_4FV( to[i], (GLfloat *)f );
> }
> }
>
OK, I've committed this. COPY_3FV merely declares a temporary pointer
to the source before copying. Gcc does better under these
circumstances.
Keith
