Hello!
Whould someone please check these changes in?
I fixes a bug in mipmapping code.
Miklos.
On Mon, 19 Apr 1999, FAZEKAS Miklos wrote:
> Hello!
>
> I've found a bug in the recent CVS version of Mesa:
> in texture.c at line 978:
> /* XXX this mix of floating point and integer math probably isn't
> * too efficient.
> */
> rgba[0] = (w00 * t00[0] + w10 * t10[0] + w01 * t01[0] + w11 * t11[0]
> + 0.002);
> rgba[1] = (w00 * t00[1] + w10 * t10[1] + w01 * t01[1] + w11 * t11[1]
> + 0.002);
> rgba[2] = (w00 * t00[2] + w10 * t10[2] + w01 * t01[2] + w11 * t11[2]
> + 0.002);
> rgba[3] = (w00 * t00[3] + w10 * t10[3] + w01 * t01[3] + w11 * t11[3]
> + 0.001);
>
> should be:
> rgba[0] = (w00 * t00[0] + w10 * t10[0] + w01 * t01[0] + w11 *
> t11[0]) >> 8;
> rgba[1] = (w00 * t00[1] + w10 * t10[1] + w01 * t01[1] + w11 *
> t11[1]) >> 8;
> rgba[2] = (w00 * t00[2] + w10 * t10[2] + w01 * t01[2] + w11 *
> t11[2]) >> 8;
> rgba[3] = (w00 * t00[3] + w10 * t10[3] + w01 * t01[3] + w11 *
> t11[3]) >> 8;
>
> Since floats were eliminated recently.
>
_______________________________________________
Mesa-dev maillist - [EMAIL PROTECTED]
http://lists.mesa3d.org/mailman/listinfo/mesa-dev