On 6/27/06, Michel Dänzer <[EMAIL PROTECTED]> wrote: > On Mon, 2006-06-26 at 22:40 +0200, Martijn van Oosterhout wrote: > > Nowhere is there any protection for negative values. If either of x1
<snip> > > Yes, please post a diff so we might get an idea what's missing still. > One thing to keep in mind is that [xy]2 must be the coordinates of the > rightmost column / bottommost line, not the ones immediately outside. I would, except I can't see where to get the screen sizes from. In the DRIscreen structure there are fields describing the size of the *framebuffer* but I'm not sure if they're the right values to use. OTOH, I might just use the method used by the X server, which is to just use a mask so negative values don't blat the wrong field. Need to test that. > See r128FlushVerticesLocked(), e.g. The thing is there's this optimisation that avoid loading the cliprects everytime if there are less than three. However, that relies on people notifying eachother when they've changed. > That's not too surprising, if you look at LOCK_HARDWARE(), it only calls > r128GetLock() if the HW lock was taken by another context since the last > time this context had it (as the drawable information can only have > changed in that case). The X server should take the lock every time it > processes any request though... It should. However, things like scrolling an xterm, changing the window focus or other screen updates don't cause r128GetLock() to be called. And in particular, I notice that the X server plays with the clipping controls during things like blits and clears. Since scrolling the xterm is clearly a blit, at that point the hardware clipping has possibly been altered and DRI state not invalidated. Oops! I don't see a quick way to read the clipping rectangles to verify this, but I'll keep playing. Have a nice day, -- Martijn van Oosterhout <[EMAIL PROTECTED]> http://svana.org/kleptog/ Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
