On Sat, 2006-07-01 at 14:43 +0200, Martijn van Oosterhout wrote:
> On 6/30/06, Michel Dänzer <[EMAIL PROTECTED]> wrote:
> > On Fri, 2006-06-30 at 11:23 -0600, Brian Paul wrote:
> > >
> > > 2. Use 'else if' since x1 can't be both < 0 and >= fbWidth
> >
> > Actually, this points out the possible source of the remaining problems:
> > x2 and y2 also need clamping to fbWidth-1 and fbHeight-1, respectively,
> > and if (x1 >= x2 || y1 >= y2), the cliprect is empty and should be
> > skipped.

Make that '[xy]2 should be clamped against fb{Width,Height}-1, not
[xy]1, and if (x1 > x2 || y1 > y2) ...'.


-- 
Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer



Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to