Hanno Böck wrote: > In various dri-drivers, DO_DEBUG is defined to 1. > > Shouldn't this be defaulted off and only enabled via -DDO_DEBUG on CFLAGS? > (suggested Patch attached) > > > > ------------------------------------------------------------------------ > > diff -Naur Mesa/src/mesa/drivers/dri/i810/i810context.h > Mesa-1/src/mesa/drivers/dri/i810/i810context.h > --- Mesa/src/mesa/drivers/dri/i810/i810context.h 2005-09-03 > 18:44:27.000000000 +0200 > +++ Mesa-1/src/mesa/drivers/dri/i810/i810context.h 2006-07-12 > 05:34:19.969527000 +0200 > @@ -227,7 +227,6 @@ > /* ================================================================ > * Debugging: > */ > -#define DO_DEBUG 1 > #if DO_DEBUG > extern int I810_DEBUG; > #else
[...] I might change the #if DO_DEBUG to just #ifdef DEBUG. The DEBUG symbol is what core Mesa uses to enable extra debug code. -Brian ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
