Allen Akin wrote: > | And, what card is this? When I run it on my radeon 9000 (rv250), I > get | only 2 (repeated for all visuals) failures: | FAILURE: | > Program: LIT test 1 | Expected color: 1, 0.65, 0.443, 1 | > Observed color: 1, 0.65098, 0.431373, 1 | FAILURE: | Program: LIT > test 2 (degenerate case: 0 ^ 0 -> 1) | Expected color: 1, 0.65, 1, > 1 | Observed color: 1, 0.65098, 0, 1 | | Both are expected, r200 > (and r300) apparently can't handle the | degenerate case (that's > really nitpicking), > > I didn't write that test, and I haven't looked into the logic behind > it, but it's possible that the OpenGL spec makes some guarantee about > the results in that case. Need to do a little research. Yes the spec requires this, sorry I wasn't clear enough. It just seems weird that it is so explicit in this case (there will always be discontinuities anyway).
> | whereas the failure in LIT test 1 is actually not a failure at all > | (glean expects an approximation but with too tight tolerance, the > value | is actually "too good"). > > This is one of those situations in which the tolerance can't reliably > be based on the depth of the color channel, but might need to be > based in part on some internal precision that there's no way to > query. > > That said, it looks to me like the main problem is that the expected > value in the test isn't accurate enough -- it should be about 0.430 > rather than 0.443. The tolerance itself looks reasonable. Since I'm > not familiar with the test I might be missing something, though. Well the spec says that the approximation functions of EXP and LOG may be used, but it doesn't seem to forbid that a more exact version gets used. I think this is where the difference in the expected result comes from. But the approximation functions of EXP and LOG are only guaranteed to be accurate to 10 bits. I didn't really look though if that translates to other needs for the tolerance level, that was just an assumption. Roland ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
