Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > It looks like adding support for GLX_SGI_make_current_read is almost as > easy as just enabling the extension thanks to Mesa's internal > framebuffer object changes. Thanks Brian! > > However, there is one thing that I don't get. Each driver supplies a > GetBufferSize callback. This callback is passed a GLframebuffer > pointer, but all of the drivers ignore it. They simply return the size > of the currently bound drawable. Should these functions determine if > the supplied GLframebuffer is the current drawable or readable and > return the appropriate size?
GetBufferSize() should return the width/height of the X window (or Pbuffer) that corresponds to the given GLframebuffer. Unfortunately, GetBufferSize() isn't correctly implemented in most (any?) DRI drivers. It really needs to be fixed to support make_current_read. In practice, the GLframebuffer will always be bound as either the context's current read buffer or draw buffer, but I wouldn't bet on that always being true down the road. I think we may need to add a void * to GLframebuffer which points back to the corresponding __DRIdrawablePrivate... -Brian ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
