Dan Nicholson wrote: > On 10/31/07, Brian Paul <[EMAIL PROTECTED]> wrote: >> Dan Nicholson wrote: >>> Some of the Linux and FreeBSD x86 (non-static) configurations remove >>> -fPIC. However, the linux-x86 target doesn't. I'm not gonna try to >>> pretend to be an expert on position-independent code, but I'm >>> wondering if this should be done. If so, should all the Linux x86 >>> targets be standardized on that? >> Well, we want PIC for shared libraries so I'd expect all the >> non-static-lib configs to use it. But I'm not an expert either... > > Right, but in linux-dri-x86 (shared), there's a comment "# Unnecessary > on x86, generally." before clearing PIC_FLAGS. Same with > freebsd-dri-x86. I know that Fedora puts the -fPIC back in for all > architectures they build. This change goes back to 2004 (0a21a4aa). > > FWIW, libtool adds -fPIC by default for shared library code on GCC > with a few exceptions.
The comment comes from Eric Anholt: Refactor the linux-dri config files so that linux-dri-x86 inherits from linux-dri. Turn on -O by default (-O2 provides a slight improvement in performance, at a large cost to debuggability). Turn off -fPIC on x86 by default. Turn on -Wall, to catch more stupid mistakes. This could be both done cleaner, and done for more config files, but it works for me for now. it seems to be we should be using -fPIC so go ahead. -Brian ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
