On Mon, 17 Mar 2008 17:49:10 +0100
Michel Dänzer <[EMAIL PROTECTED]> wrote:
>
> On Mon, 2008-03-17 at 12:10 +0100, Jerome Glisse wrote:
> >
> > Markus i think you should apply for an account you have provided
> > several good patch for r300, there is the procedure on fdo.
>
> I'm afraid this may be a little premature yet:
>
> Commit f0c8863dbb71b2c3605bb8eb9526c7d8d13793cf ('r300: Simplify
> r300VAPInputRoute0, check for valid input.') makes any 3D app lock up
> the RV350 in my PowerBook immediately.
>
> Commit c48212fe5861291efd134b35e67568c79b15f960 ('r300: Simplify
> r300VAPInputRoute1.') causes non-opaque windows to be corrupted with
> compiz.
>
> I'm currently running master with these two reverted and haven't noticed
> any other regressions yet.
>
>
My fault i haven't tested the patch, they looked good from a quick
review. Michel does memsetting to 0 the whole dst area in
begining of functions help. Only difference i can see is when we got
only one input and so the upper half of the dword might have some
garbage. Between as you are powerpc user maybe this is somethings
to do with that BE/LE and dst16.
If memsetting doesn't help feel free to revert them in master.
I won't have time before next week to look at this. All my
apologizes for that poor review.
Cheers,
Jerome Glisse <[EMAIL PROTECTED]>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev