Alan Coopersmith wrote:
> I needed to apply the attached patches to git master to be able to build
> on Solaris using the autoconf support and the Sun compilers - can they be
> included for the 7.1 release?
>
> There were two big portability problems I worked around instead of fixing:
> - Use of __inline and __inline__ instead of glheader.h's INLINE
> - Use of u_int{8,16,32}_t types instead of the C99 standard
> uint{8,16,32}_t
>
> Since the Sun compilers and current Solaris headers are C99 compliant,
> the standard forms (inline, uint*_t) work, but I had to add #defines
> to map all the places the non-portable versions are used instead. I
> started doing global replaces to make all the mesa source consistent,
> but the changes quickly became far larger than I wanted to submit this
> close to a release, and adding the #defines protects the Solaris port
> against future instances of these things coming back in.
I'll commit this, but I think some follow-up work should be done.
For example, all the __inline__ usage in the DRI driver code should use
the INLINE macro.
I'd also like to re-org the stuff in glheader.h and imports.h into more
logical groups.
Replacing u_int8_t with uint8_t, etc. seems desirable too. I'm not sure
why the former convention was used.
-Brian
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
