OK by me. In general, if there's no feedback to a patch it's most likely silence consensus.
-Brian Dan Nicholson wrote: > Any issues with this patch? I'll probably push it if there are no objections. > > > On Wed, Jun 4, 2008 at 1:26 PM, Dan Nicholson <[EMAIL PROTECTED]> wrote: >> Rather than just defining HAVE_POSIX_MEMALIGN on Linux, check whether >> the function exists on all platforms and define the macro if it is. >> --- >> Dan >> >> This seems like the right thing to do, but I only have Linux to test >> on. Any BSDers know if this is alright? As I understand it, >> posix_memalign is available in FreeBSD-7.0, in which case I'd think >> you'd want to use it. >> >> configure.ac | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index f289501..207e53d 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -73,7 +73,7 @@ linux*) >> if test "x$GCC" = xyes; then >> DEFINES="$DEFINES -D_POSIX_SOURCE -D_POSIX_C_SOURCE=199309L >> -D_BSD_SOURCE" >> fi >> - DEFINES="$DEFINES -D_SVID_SOURCE -D_GNU_SOURCE -DPTHREADS >> -DHAVE_POSIX_MEMALIGN" >> + DEFINES="$DEFINES -D_SVID_SOURCE -D_GNU_SOURCE -DPTHREADS" >> ;; >> esac >> >> @@ -310,6 +310,9 @@ dnl has it in libc), or if libdl is needed to get it. >> AC_CHECK_FUNC([dlopen], [], >> [AC_CHECK_LIB([dl], [dlopen], [DLOPEN_LIBS="-ldl"])]) >> >> +dnl See if posix_memalign is available >> +AC_CHECK_FUNC([posix_memalign], [DEFINES="$DEFINES -DHAVE_POSIX_MEMALIGN"]) >> + >> dnl SELinux awareness. >> AC_ARG_ENABLE([selinux], >> [AS_HELP_STRING([--enable-selinux], >> -- >> 1.5.3.2 >> >> >> ------------------------------------------------------------------------- >> Check out the new SourceForge.net Marketplace. >> It's the best place to buy or sell services for >> just about anything Open Source. >> http://sourceforge.net/services/buy/index.php >> _______________________________________________ >> Mesa3d-dev mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev >> > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > Mesa3d-dev mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev > ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
