On Fri, Oct 10, 2008 at 4:52 PM, Ralovich, Kristóf <[EMAIL PROTECTED]> wrote: > On Thu, Sep 11, 2008 at 19:47, Brian Paul > <[EMAIL PROTECTED]> wrote: >> Ralovich, Kristóf wrote: >>> >>> Hi Brian, >>> >>> since I am spending a lot of time tampering in src/glx/x11 I would >>> like to offer my help to re-indent and untabify at least some of the >>> files (glxcmds.c, glxext.c, glx_query.c, glxcurrent.c, these files are >>> authored by SGI and usually have 4 space indenting) in that directory >>> and put the >>> >>> -*- mode: c; tab-width: 3; indent-tabs-mode: nil; c-basic-offset: 3; >>> coding: utf-8 -*- >>> >>> emacs helping line into the header comments. If you accept my >>> proposal, I am going to post my patches as soon as I can! This would >>> greatly simplify accepting xcb-glx patches I am working on into >>> upstream Mesa. If this is not the way to go, what is the guideline >>> indenting new code going into these files? >>> >>> I am looking forward to hearing from you! >> >> I'm in favor of running 'indent' on all the glx sources to clean them up. >> >> However, let's wait a bit. We're in the middle of merging the gallium >> branch to master (via the new gallium-0.2 branch) and a bunch of whitespace >> changes would probably just be a hinderance at this point. >> >> Can you wait a week or two? >> >> -Brian >> >> > > Just a small reminder, since a month is gone. Do you see the time it > would be appropriate for me to provide the patches reindenting > src/glx/x11 ? Shall I make the patch against master or gallium-0.2?
I actually don't think this will cause any difficulty with merges, so I'd say just go ahead. Probably doing it to master would be best as we're regularly merging that into gallium-0.2. Keith ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
