Eric Anholt wrote: > To follow is a patch series started by looking into #18914. With it > fbo_firecube runs, and I'm farther through the FBO testcases in our oglconform > than ever before, in both hardware and software. I'm especially interested in > review on ctx->Driver.GenerateMipmap interface and whether having > SGIS_generate_mipmap smarts to get wrong in the driver is appropriate (I > think not, but it's the status quo).
Your patch looks OK (I just took a quick look). FYI: in Gallium things like generate_mipmap, glDrawPixels, glBitmap, etc. are all implemented in utility functions that the driver doesn't have to care about. With some work, the same could probably be done in the regular Mesa/DRI drivers. > Well, and someone making sure my coordinate space adventures in > bitmap/copypixels are correct. Because I get those wrong all the time. Yeah, the up/down orientation of window renderbuffers and user-created renderbuffers is different, but there's really no way around that. I could dig up an old email that explains it all if anyone's interested. -Brian ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
