On Mon, 2009-01-12 at 13:21 +0100, Stephane Marchesin wrote: > On Mon, Jan 12, 2009 at 13:18, Michel Dänzer <mic...@daenzer.net> wrote: > > > > Without something like the patch below, gallivm doesn't work on my > > PowerBook; ParseBitcodeFile() complains that the data isn't terminated > > by a 0 byte, or, if only the size passed to MemoryBuffer::getMemBuffer > > is decreased by 1, that its size doesn't match some alignment or > > whatever requirement. I suspect it only works on other setups because > > the first byte in memory after the bitcode array happens to be 0. > > > > Note that gallivmsoabuiltins.cpp doesn't seem to be in Git (should it > > be?) and needs to be re-generated after this change. Also, I don't seem > > to be exercising gallivm_builtins.cpp and friends, so I can't be sure > > that path really needs the same treatment. FWIW though it already has > > the buffer size decreased by 1. > > > > Yeah, we discussed this before and it's needed.
Okay pushed, thanks. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ------------------------------------------------------------------------------ Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about anything Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
