On Mon, Jan 12, 2009 at 09:56:30AM -0800, Dan Nicholson wrote:
> On Mon, Jan 12, 2009 at 7:04 AM, Julien Cristau <jcris...@debian.org> wrote:
> > Fixes build on arm-linux-gnueabi
> > ---
> >  configure.ac |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index d3a9364..6a99f30 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -83,7 +83,7 @@ dnl Compiler macros
> >  DEFINES=""
> >  AC_SUBST([DEFINES])
> >  case "$host_os" in
> > -*-gnu)
> > +*-gnu*)
> >  if test "x$GCC" = xyes; then
> >     DEFINES="$DEFINES -D_POSIX_SOURCE -D_POSIX_C_SOURCE=199309L 
> > -D_BSD_SOURCE"
> >  fi
> 
> Seems fine to me, although the whole macro game is a little silly.
> Correct me if I'm wrong, but doesn't _GNU_SOURCE
> encompass all of _POSIX_SOURCE _BSD_SOURCE and _SVID_SOURCE? In that
> case, couldn't we just define _GNU_SOURCE on gnu systems and call it a
> day?

Does defining _GNU_SOURCE actually cause those other things to be
defined?  What happens if there are places in the Mesa code that check
for, say, _POSIX_SOURCE to select a code path?  I don't think anything
like that exists today, but I'd rather be safe than sorry.

Attachment: pgpN2mNyEbPxp.pgp
Description: PGP signature

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to