On piątek, 24 kwietnia 2009 16:42:53 you wrote:
> Hi,
>
> among some general cleanup this patchset contains performance regression
> fix for non TCL cards, and some debugging related improvements.
> Any comments?
>
> Regards,
> Maciej Cencora
please replace the last patch with these two. Since the patch that fixes perf
regression we use fixed function SWTCL if possible for non TCL hardware, we
need to add point attenuation stage.
Maciej Cencora
From c95187776b6ec97f27959715ac4d75b4c5fc86ce Mon Sep 17 00:00:00 2001
From: Maciej Cencora <[email protected]>
Date: Fri, 24 Apr 2009 16:28:47 +0200
Subject: [PATCH] r300: fix performance regression
This performance regression on non TCL hw was introduced by ed4c6cbe017b4e8bacb7e012d4baaf77a20a2c33.
This patch depends on "r300: always route 4 texcoord components to RS" and "r300: add point attenuation stage for TCL fallbacks".
---
src/mesa/drivers/dri/r300/r300_context.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/r300/r300_context.c b/src/mesa/drivers/dri/r300/r300_context.c
index 5119890..c80dcd8 100644
--- a/src/mesa/drivers/dri/r300/r300_context.c
+++ b/src/mesa/drivers/dri/r300/r300_context.c
@@ -364,7 +364,10 @@ GLboolean r300CreateContext(const __GLcontextModes * glVisual,
ctx = r300->radeon.glCtx;
r300InitConstValues(ctx, screen);
- ctx->VertexProgram._MaintainTnlProgram = GL_TRUE;
+
+ if (hw_tcl_on)
+ ctx->VertexProgram._MaintainTnlProgram = GL_TRUE;
+
ctx->FragmentProgram._MaintainTexEnvProgram = GL_TRUE;
/* Initialize the software rasterizer and helper modules.
--
1.5.6.3
From ca418a4b1574d6caee32455cac89104601625dad Mon Sep 17 00:00:00 2001
From: Maciej Cencora <[email protected]>
Date: Fri, 24 Apr 2009 16:52:33 +0200
Subject: [PATCH] r300: add point attenuation stage for TCL fallbacks
---
src/mesa/drivers/dri/r300/r300_context.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/mesa/drivers/dri/r300/r300_context.c b/src/mesa/drivers/dri/r300/r300_context.c
index 3bde9ca..5119890 100644
--- a/src/mesa/drivers/dri/r300/r300_context.c
+++ b/src/mesa/drivers/dri/r300/r300_context.c
@@ -172,6 +172,7 @@ static const struct tnl_pipeline_stage *r300_pipeline[] = {
&_tnl_fog_coordinate_stage,
&_tnl_texgen_stage,
&_tnl_texture_transform_stage,
+ &_tnl_point_attenuation_stage,
&_tnl_vertex_program_stage,
/* Try again to go to tcl?
--
1.5.6.3
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensign option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
