On Wed, Apr 22, 2009 at 4:42 PM, Samuel Thibault
<[email protected]> wrote:
> Hello,
>
> Dan Nicholson, le Wed 22 Apr 2009 06:31:54 -0700, a écrit :
>> Could you split the patch in two? One patch for direct rendering fixes
>> and one for hurd specific fixes?
>
> Sure. Attached patch-mesa-gnu is
>
> - dri_interface.h: no libdrm support either.
> - configure.ac:
>  - GNU/Hurd is a GNU OS with _GNU_SOURCE and PTHREADS.
>  - GNU needs a couple of flags like other OSes.
>
> and can probably be applied without problem indeed.
>
> patch-mesa-nongnu is
>
> - dri2.c: only compile if GLX_DIRECT_RENDERING
> - configure.ac: libdrm should only be required if direct rendering is enable, 
> which
>    then should be configured earlier.

Applied.

>> I'd like to get confirmation from someone more knowledgeable about
>> DRI to confirm that libdrm and dri2.c are not needed without direct
>> rendering. I'm hitting build errors on i915 with this patch and
>> --disable-driglx-direct because it's still pulling in drm.h. I'm
>> guessing you want swrast only, which is not the same as indirect only.
>
> Well, the thing is: GNU/Hurd does not have libdrm because it uses ioctls
> that do not exist (and actually can not be expressed at the moment) on
> GNU/Hurd.

I certainly understand why you can't use libdrm on hurd, but I don't
know if it's appropriate for the current code to skip it for
indirect-only. The fact is that you can still build the drivers and
have them only accessed indirectly.

Perhaps we need a check for whether the platform is drm-capable or
not. If not, then you're limited to indirect-only with swrast and we
don't check for libdrm and friends. I'm cc'ing Jeremy Huddleston to
see how they deal with this for darwin.

--
Dan

------------------------------------------------------------------------------
Crystal Reports &#45; New Free Runtime and 30 Day Trial
Check out the new simplified licensign option that enables unlimited
royalty&#45;free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to