Chris Clayton wrote: > Hi, > > I've been chasing a random crash in an application called Smile > (http://smile.tuxfamily.org/). I > believe I've traced to an uninitialsed function pointer in libMesa. The patch > below seems to have > fixed the crashes.in 7.4.1 - I haven't tested earlier versions but I was also > getting the crash in > 7.4. Without the patch, I got a crash at line 661 of > Mesa-7.4.1/src/glx/x11/glxcmds.c/ My > investgations showed that psc->driScreen->waitX had a value of either NULL or > 0x100, that latter of > which was, of course, defeating the != NULL test that guards the dereference. > > --- Mesa-7.4.1/src/glx/x11/drisw_glx.c~ 2009-05-02 23:31:59.000000000 +0000 > +++ Mesa-7.4.1/src/glx/x11/drisw_glx.c 2009-05-02 23:35:09.000000000 +0000 > @@ -363,6 +363,8 @@ > if (psp == NULL) > return NULL; > > + psp->waitX = NULL; > + > /* Initialize per screen dynamic client GLX extensions */ > psc->ext_list_first_time = GL_TRUE; > > > I'm not subscribed, so please cc me on any reply.
Thanks. I think I'll fix this by changing the Xmalloc() into an Xcalloc() to be extra safe. I think there's more than one occurance of this too... -Brian ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
