On Tuesday 14 July 2009 10:55:32 Keith Whitwell wrote:
> On Sat, 2009-07-11 at 10:45 -0700, Zack Rusin wrote:
> > Module: Mesa
> > Branch: mesa_7_5_branch
> > Commit: 1c1307e7c55844f63f7bd7ac02c64f4b936f3c66
> > URL:   
> > http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c1307e7c55844f63f7bd7ac
> >02c64f4b936f3c66
> >
> > Author: Zack Rusin <za...@vmware.com>
> > Date:   Sat Jul 11 13:48:41 2009 -0400
> >
> > gallium: compare the actual register, not all the inputs
> >
> > otherwise we decrement indexes for all registers
> >
> > ---
> >
> >  src/mesa/state_tracker/st_atom_shader.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/mesa/state_tracker/st_atom_shader.c
> > b/src/mesa/state_tracker/st_atom_shader.c index 5219119..8b3bb5c 100644
> > --- a/src/mesa/state_tracker/st_atom_shader.c
> > +++ b/src/mesa/state_tracker/st_atom_shader.c
> > @@ -139,7 +139,7 @@ find_translated_vp(struct st_context *st,
> >           if (fragInputsRead & (1 << inAttr)) {
> >              stfp->input_to_slot[inAttr] = numIn;
> >              numIn++;
> > -            if ((fragInputsRead & FRAG_BIT_FOGC)) {
> > +            if (((1 << inAttr) & FRAG_BIT_FOGC)) {
>
> Zack,
>
> Would it have been easier to say something like
>
>    if (inAttr == FRAG_ATTRIB_FOGC) {
>
> to achieve this?

yes, most definitely.


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to