Keith Whitwell pisze: > Remove the need to have a pointer in this struct by just including > the immediate data inline. Having a pointer in the struct introduces > complications like needing to alloc/free the data pointed to, uncertainty > about who owns the data, etc. There doesn't seem to be a need for it, > and it is unlikely to make much difference plus or minus to performance. >
This patch is OK, though it heavily relies on the fact the immediates are always stored as float quadruplets. We either need to add a bunch of asserts about that, or specialise the tgsi representation by removing NrTokens field and make it explicit we are dealing with exactly four values, not (NrTokens-1). ------------------------------------------------------------------------------ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
