Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I just pushed a branch that implements the new GL_ARB_sync extension. > It is currently only supported for the software rasterizer, but I > believe the Eric and I will be able to add support to the Intel drivers > (that use GEM) tomorrow. I am hoping to merge this branch to master in > the next few days. > > Before I merge this branch, I'd like a little review. In particular, > I'd like for folks to review the locking around ctx->Shared. I'm 90% > confident that what I have implemented gives the correct semantic, but > I'd really like to have some more eyes on it.
Looks OK. Though, someday I'd like to review the use of ctx->Shared->Mutex of everywhere. I think we should probably have a per-object type lock intead of just one big lock. But multi-context, multi-threaded apps aren't too common so I'm not in a big hurry. Other than that, I have just a few minor suggestions: 1. Instead of (*ctx->Driver.DeleteSyncObject)(ctx, syncObj); use ctx->Driver.DeleteSyncObject(ctx, syncObj); Etc. 2. Replace: const GLsizei copy_count = (size > bufSize) ? bufSize : size; with: const GLsizei copy_count = MIN2(size, bufSize); 3. Replace double blank lines in functions with a single blank line. 4. Remove unneeded #include "hash.h" 5. Add syncobj.c to SConscript -Brian ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
