Michel Dänzer wrote:
> On Mon, 2009-09-21 at 16:46 +0200, mic...@daenzer.net wrote:
>> From: Michel Dänzer <daen...@vmware.com>
>>
>> Since commit 6f9dbe773953b024075910b3bec11ebc96c2e8e0 ('mesa: use new
>> _mesa_meta_CopyTex[Sub]Image() functions'), I was seeing crashes when using
>> the
>> compiz magnifier plugin, apparently because the code in radeon_texture.c ends
>> up unmapping a texture BO more times than it was mapped. There may be a
>> better
>> fix for that particular problem, [...]
>
> Actually the patch turned out not to fix the compiz magnifier plugin
> problem completely. The patch below does, does it look good?
>
> * Make sure the texture has a valid format in copy_tex_image().
> * Move up the _mesa_update_state() call in _swrast_ReadPixels(),
> so the driver doesn't map the wrong textures.
> * Make the radeon texture (un)mapping code cope with textures
> which don't have a miptree associated with them yet.
Looks good to me. Thanks, Michel.
-Brian
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
