On Sun, 2009-09-27 at 19:30 -0700, Younes Manton wrote: > On Thu, Sep 17, 2009 at 2:29 PM, Zack Rusin <za...@vmware.com> wrote: > > On Thursday 17 September 2009 13:21:45 Younes Manton wrote: > >> On Thu, Sep 17, 2009 at 12:43 PM, Zack Rusin <za...@vmware.com> wrote: > >> > Hey, > >> > > >> > I'm going to start adding XvMC acceleration to the Gallium's xorg state > >> > tracker. > >> > I'd like to move src/xvmc to src/gallium/state_trackers/xorg/xvmc and run > >> > the standard Mesa3D indent command on both g3dvl and xvmc. > >> > > >> > I'm by no means saying that the style in them is bad, or that any style > >> > is better than any other. What I am saying is that when working within a > >> > project that has a well defined indention (docs/devinfo.html) it's > >> > anti-social and difficult for everyone involved when parts of the code > >> > are using something completely different. It's unrealistic to expect > >> > people to keep switching indention that drastically when moving between > >> > files within a project. So all I'm asking for is some consistency which I > >> > think is going to make everything a lot easier for all of us. > >> > > >> > z > >> > >> Be my guest. > > > > Great, thanks Younes. > > > > > >> But aside from that I'm still messing with the pipe_video_context > >> stuff I proposed a while back, which carves up state_trackers/g3dvl > >> pretty good and which might make what you want to do a little easier. > >> At the moment it compiles and "runs" (no output to window, everything > >> safely stubbed, slowly porting over what used to be the state tracker > >> into aux libs), if you have any interest. Maybe I can put it somewhere > >> so people can comment on the interface and auxiliaries if nothing > >> else. > > > > Sounds like a good idea. > > We're on a schedule for XvMC in the xorg state tracker so we might have to > > get > > that just working first. But there's substantial interest in OpenMAX state > > tracker, plus support for things like vdpau and it would be great if we > > could > > do it all properly. > > > > z > > > > Ok I just pushed this all out and moved xvmc under xorg. > state_trackers/g3dvl is now completely useless and I'll delete it > soon.
Younes, Large changes like this should be rehearsed in a feature branch, to allow for more review and experimentation while keeping master from getting too broken. > pipe_video_context and vl_compositor still need some love for Xv and > more love for VDPAU. > > pipe_video_context needs a function to set a colour conv matrix & > procamp for hue/saturation/brightness/etc. Right now vl_compositor > sets its own matrix internally for csc and doesnt do procamp. There > needs to be a way to map pipe_video_surface to be able to upload > already decoded frames, either pipe_transfer can become a little more > general or there can be separate transfer objects. > > The winsys/g3dvl dir is probably out of place. There's already an xlib > winsys dir so maybe we can have xlib/mesa, xlib/xorg, xlib/xorg/xvmc > to match how winsys/drm is set up now. I hadn't time to review pipe_video_context yet, but a few quick comments to your changes: - Avoid unsupported C99 features in code that will be build in all architectures (especially, src/gallium/auxiliaries, src/gallium/drivers): use p_compiler.h instead of stdbool.h; declare all variables on top of the scope. I already fixed all issues that were causing build failures on MSVC, but please keep this in mind on future changes. - Please add copyright headers. Jose ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
