On Tue, Nov 24, 2009 at 12:37 PM, tom fogal <[email protected]> wrote:
> Dan Nicholson <[email protected]> writes:
>> On Thu, Nov 19, 2009 at 8:28 AM, Brian Paul <[email protected]> wrote:
>> > tom fogal wrote:
>> >> Brian Paul <[email protected]> writes:
>> >>> Please test and report any problems ASAP. If there aren't any issues
>> >>> we'd like to release 7.6.1 on Friday or Saturday.
> [snip]
>> >> Secondly, the AIX build is failing in progs/Makefile. The
>> >> quoting introduced in 115edf24a9128b79dfa5f30482c990e2cb898357
>> >> and removed in 31f7e8efb25a77e3bdfb6e9850cf31e339060976 was
>> >> important. Otherwise, SUBDIRS will end up being " " or maybe " "
>> >> and test -n will (annoyingly) fail, causing the `for'-over-nothing
>> >> to execute.
>> >
>> > The $(strip ...) syntax is GNU-make specific, I think. If it
>> > causes trouble for anyone we'll revisit it.
>>
>> Sorry, I meant to comment on this earlier, but I was really busy.
>
> It happens, no worries.
>
>> I think the reason that the make variable ends up with a space
>> in it instead of being empty is the automatic demos checking in
>> configure. I think it would be better to fix it there so that you
>> either get a list of directories or an empty variable. I don't have
>> time to test, but I think this would fix it:
>
> I think you're right, but unfortunately that's not the only change that
> needs to be made. configs/default (IIRC) sets PROGRAM_DIRS as well,
> which I think is the issue Brian ran into that caused him to originally
> revert this part of the patch.
>
> I toyed with the idea of making:
> PROGRAM_DIRS = demos blah whatever
> into:
> PROGRAM_DIRS ="demos blah whatever"
>
> in configs/default, but I felt that was too fragile; anyone that
> then modified configs/default (or a config that included it, where
> they wanted to change this) would need to know about this weird
> stringification-with-no-spaces requirement, and no other variables need
> that behavior.
>
>> - PROGRAM_DIRS="$demos"
>> + PROGRAM_DIRS=`echo $demos | $SED 's/^ *//'`
>
> ... we might consider doing something like this instead of $(strip) in
> the makefile; this seems more portable (i.e. would work w/o GNU make).
>
> ... all that said, we could, of course, just go with something like
> this and ignore the non-autoconf case. I certainly don't care about
> the non-GBS for my work. It leaves the lurking case where one can't:
>
> PROGRAM_DIRS =
> ^ (there's a space here [1] ;)
>
> in a config/ though. *shrug*. As I said, it doesn't matter much for
> me.
Actually, I don't know why this is a problem. On my system with GNU
make (which you're using, too) having just spaces after the = gets
stripped.
$ cat > Makefile << "EOF"
DIRS = # bunch of spaces here
SUBDIRS = $(DIRS)
dirs:
@echo '"$(SUBDIRS)"'
@test -n "$(SUBDIRS)" && echo non-empty || echo empty
EOF
$ make dirs
""
empty
What is the actual error you're seeing?
31f7e8efb25a77e3bdfb6e9850cf31e339060976 is definitely correct as the
quotes would cause all the directories to be a single argument. Can
you try the automake way, which I believe is used to workaround this
exact issue? It constructs the for loop using a shell variable instead
of a make variable.
subdirs:
@list='$(SUBDIRS)'; for dir in $$list; do echo $$dir; done
>> Tom, what arguments do you pass to configure?
>
> FWIW on AIX we do something like this:
>
> ./configure CC=xlc CXX=xlC CFLAGS=-qcpluscmt -qlanglvl=extc99
> -DUSE_MGL_NAMESPACE CXXFLAGS=-DUSE_MGL_NAMESPACE
> --prefix=/usr/common/homes/f/fogal1/sw
> --without-demos --with-driver=xxx --disable-gallium --with-max-width=16384
> --with-max-height=16384 --disable-glw --disable-glu --disable-egl
>
> Except it happens twice, the first time with xxx=xlib and the latter
> with xxx=osmesa. If you're *really* curious, see the function
> 'build_mesa' in:
>
> http://portal.nersc.gov/svn/visit/trunk/src/svn_bin/build_visit
That's strange since --without-demos will substitute PROGRAM_DIRS="".
I think there's something else funky going on.
--
Dan
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
