On Wed, 2010-01-06 at 16:47 -0800, Mike Stroyan wrote: > Hello folks. I started at LunarG this week and have been getting more > familiar with > the gallium code. > > I noticed that rbug-gui has not been updated to match the recent > changes to > the util_format. Here is a patch that switches from the pr_* > functions to util_format > functions. (It also adds several new icons for the many formats.) > I replaced the 'action->block' field with just one > 'action->block_height' field. > That is the only part of action->block that is needed if > util_format_get_nblocksx > is called instead of pf_get_nblocksy. > I don't know if there is a better way to extract block height from > format instead > keeping it as a separate field. > > Do these changes look good? > > Mike Stroyan, m...@lunarg.com
Mike, It looks like there are some unrelated changes in your diff -- can you separate them out into disjoint changes? One way is to make several commits to your local git repo and then use git-format-patch to create email-ready changes with your authorship and commit message intact. Keith ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
