On Fri, Jan 22, 2010 at 12:40 AM, Dan Nicholson <dbn.li...@gmail.com> wrote:
> 2010/1/21 Chia-I Wu <olva...@gmail.com>:
>> 2010/1/21 Tomáš Chvátal <scarab...@gentoo.org>:
>>>> The patches look good to me. There is a typo in the second patch
>>>>
>>>> - $(OBJECTS) $(DRM_LIB) $(MISC_LIBS)
>>>> + ${LDFLAGS} $(OBJECTS) $(DRM_LIB) $(MISC_LIBS)
>>>> Should be $(LDFLAGS), right?
>>> Indeed it should be $(LDFLAGS).
>>> Tho it fixes the problem anyway because LDFLAGS are still exported in
>>> the ENV. (so in theory it should not differ if we use make macro or the
>>> env content)
>>> Should i repost the patch or commiter will sed it?
>> It seems LDFLAGS is still missing in some of the Makefiles, but it would be a
>> boring task to add it to the other Makefiles and test them.
>>
>> I will commit the patches tomorrow, if no one objects or commits them today.
>
> mklib is stupid about arguments, so the proper way to do this is to
> pass -ldflags '$(LDFLAGS)'. Then it will not try to process random
> flags as if they're library deps or anything else. See
> glx/x11/Makefile for example. The LDFLAGS should be used whenever
> we're going to build a non-internal library.
>
> I wouldn't depend on LDFLAGS being in the environment if mklib is
> being called from a Makefile. That's highly dependent on how make runs
> and might change depending on which make is in use.
I've pushed an updated version of patch 0003. It uses -ldflags to pass LDFLAGS
and removes the unused $(LIBNAME_EGL) target.
I am going to make some changes to the EGL drivers today and the other two
patches won't apply anymore. I will pay more attension to LDFLAGS while at it.
-olv
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
