On Fri, Jan 22, 2010 at 10:31 AM, Chia-I Wu <olva...@gmail.com> wrote:
> On Thu, Jan 21, 2010 at 9:53 PM, Dan Nicholson <dbn.li...@gmail.com> wrote:
>> On Thu, Jan 21, 2010 at 2:29 AM, Chia-I Wu <olva...@gmail.com> wrote:
>>> This is one of the changes I want to do for a while.  GLX was built 
>>> specially
>>> and before Mesa core because libglapi.a could not be built with 
>>> IN_DRI_DRIVER
>>> defined.  This is no longer the case for a while.
>> Interesting. I never knew that was the reason why. Two comments:
>> 1. You changed CORE_DIRS to SRC_DIRS in configure.ac. What effect does
>> that have? I think you need to keep it CORE_DIRS to make sure it
>> builds before glew.
> GLX doesn't seem to depend on GLW, does it?
> CORE_DIRS is added by the opengl-es-v2 branch.  It is never exported and its
> value will be prepended to SRC_DIRS.  Its value, for example, may be something
> like "glsl mesa mesa/es".  The purpose is to insert "mesa/es" to SRC_DIRS at a
> position after "glsl" and before "gallium" when OpenGL ES is enabled.
>> 2. The glapi.a target in glx/x11/Makefile will normally not be used,
>> but it should use $(MAKE) instead of make. And it should suppress the
>> command with @.
> I've updated the patch to use @$(MAKE) and -C.  Please have a look.
I've commited this version.  I've compared the outputs of glx/x11/ after
preprocessing (gcc -E), and they are identical.  It should be a safe change.

If I find some time, I want to move main/dispatch.c to glapi/ and move
glapi/dispatch.h to main/.  dispatch.c is a glapi source and it is weird to
have it in main/;  On the other hand, dispatch.h is a core mesa header and it
is also weird to have it in glapi/.  It will be more clear that core mesa is
the sole user of IN_DRI_DRIVER after the change.

-olv

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to