Keith Whitwell wrote:
> On Mon, 2010-01-25 at 06:05 -0800, michal wrote:
>> Brian Paul wrote on 2010-01-22 17:56:
>>> michal wrote:
>>>   
>>>> Brian Paul wrote on 2010-01-21 21:57:
>>>>     
>>>>> michal wrote:
>>>>>   
>>>>>       
>>>>>> Hi,
>>>>>>
>>>>>> This simple feature branch adds support for two-dimensional constant 
>>>>>> buffers in TGSI.
>>>>>>
>>>>>> An example shader would look like this:
>>>>>>
>>>>>> FRAG
>>>>>>
>>>>>> DCL IN[0], COLOR, LINEAR
>>>>>> DCL OUT[0], COLOR
>>>>>> DCL CONST[1][1..2]
>>>>>>
>>>>>> MAD OUT[0], IN[0], CONST[1][2], CONST[1][1]
>>>>>>
>>>>>> END
>>>>>>
>>>>>> For this to work, one needs to bind a buffer to slot nr 1 containing at 
>>>>>> least 3 vectors.
>>>>>>     
>>>>>>         
>>>>> Just a terminology thing: this feature really implements arrays of 
>>>>> constant buffers, not really two-dimensional buffers, right?
>>>>>
>>>>>   
>>>>>       
>>>> That's correct -- the access to constbuf data is two-dimensional, but 
>>>> the constbufs themselves are an array of differently-sized constat buffers.
>>>>
>>>>     
>>>>> In p_state.h we should probably rename PIPE_MAX_CONSTANT to 
>>>>> PIPE_MAX_CONSTANT_BUFFERS to be clearer.
>>>>>
>>>>> Don't we need a new PIPE_CAP_MAX_CONSTANT_BUFFERS query?  Maybe even a 
>>>>> query per shader stage?
>>>>>
>>>>>   
>>>>>       
>>>> What about maximum size of a single constant buffer? I would think this 
>>>> is a more crtical parameter than the number of constbuf slots the driver 
>>>> support.
>>>>     
>>> Yeah, I thought we already had a query for that, but we don't.
>>>
>>> I'd suggest:
>>>
>>> PIPE_CAP_MAX_CONST_BUFFERS
>>> PIPE_CAP_MAX_CONST_BUFFER_SIZE  (in bytes)
>>>
>>>   
>> All,
>>
>> Thanks for your comments, I have commited my changes to the branch and 
>> am awaiting for more comments.
> 
> Michal,
> 
> Looks good to me.  Go ahead and merge when you're ready.

Yes, I reviewed the branch too and it looks good.  Thanks.

-Brian


------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to