On Mon, Feb 1, 2010 at 9:15 AM, Mike Stroyan <m...@lunarg.com> wrote:
>  The changes to load EGL drivers by pattern matching had the side effect of 
> not
> looking in the directories specified by LD_LIBRARY_PATH or -rpath or ldconfig.
> This patch changes the search to first look in the directories listed in
> LD_LIBRARY_PATH.  To do that it moves the possible addition of a path prefix
> from make_library_path() into open_library().
>  This patch doesn't add searches in the -rpath or ldconfig directories.
> Those would be more difficult (or impossible) to determine in a portable 
> manner.
I am leaning toward something similar to how DRI drivers are loaded: Allow the
users to specify the search directory through EGL_DRIVERS_PATH.

It also seems EGL will need a check for setuid in both EGL_DRIVER (my fault)
and the proposed EGL_DRIVERS_PATH.
>  The patch also tightens up the library suffix test with a specific
> match for the suffix
> at the end of the EGL_DRIVER name.
I want to avoid suffix matching somehow.  Do you have a specific example why
the change is needed?  Or, will the following change suffice?

   p = strrchr(name, '.');
   need_suffix = (!p || (strchr(p + 1, '/') != NULL));

-olv

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to