On Thu, Feb 18, 2010 at 2:12 PM, Sedat Dilek <sedat.di...@googlemail.com> wrote:
> Hi,
>
> Debian has dash as standard /bin/sh, this breaks mesa:
>
> commit d6f55492af3cb82b0113fe6beac0f3494b6e2956
> "Make mklib propogate all errors"
>
> $ ls -l /bin/sh
> lrwxrwxrwx 1 root root 4 2009-09-17 12:53 /bin/sh -> dash
>
> checkbashisms script reports the following bashisms:
>
> $ checkbashisms mesa/bin/mklib
> possible bashism in mesa/bin/mklib line 29 ('function' is useless):
> function errtrap {
> possible bashism in mesa/bin/mklib line 447 (type):
> elif [ `type g++` ] ; then
>
> As a quick fix, I changed in bin/mklib from /bin/sh to /bin/bash.
> That works for me.
> Not sure how you wanna fix this properly.
Yeah, this should be reverted. See bug 26632.
http://bugs.freedesktop.org/show_bug.cgi?id=26632
The only portable way to do this will be to just check the return
value for all relevant commands. That should basically be anything
using ar or $LINK, but I haven't looked closely.
--
Dan
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
