Marek,
I don't particularly like that patch, because it doesn't really fix the
problem with the extension handling.
There are lots of extension listed there which should not be advertized
by default, so picking one out won't fix the others.
I think they are there because driInitExtensions definitely does more
than just set ctx->Extensions_foo_bar to enable.
Other extensions in this list which are queried by CAP bits but still
show up in the extension string regardless are the glsl ones
(ARB_fragment_shader and friends), a couple texture address modes
(mirrored_repeat, mirror_clamp), blend_equation_separate, technically
even ARB_multitexture (though we probably should skip the test for more
than 1 texture unit and always set that to true in st_extensions.c),
two-sided stencil, occlusion queries, anisotropic filtering, ycbcr
textures, packed depth stencil (there may be more that was just from a
quick look).
So if it's ok to remove them all from that list this should be done, but
I fear it's not ok and the fix needs to be a bit more complicated (see
comments in dri_init_extensions).
Roland
On 21.02.2010 16:00, Marek Olšák wrote:
> Hi,
>
> the attached patch modifies st/dri to not enable EXT_draw_buffers2 by
> default because r300g and most probably even some other drivers can't
> support this extension. The drivers reporting support of
> PIPE_CAP_INDEP_BLEND_ENABLE are not affected by this patch.
>
> Please review.
>
> Marek
>
>
> ------------------------------------------------------------------------
>
> From ddda2c19b74780263f848ffafe10809bd6385d01 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Marek=20Ol=C5=A1=C3=A1k?= <mar...@gmail.com>
> Date: Sun, 21 Feb 2010 01:27:09 +0100
> Subject: [PATCH 2/2] st/dri: don't enable EXT_draw_buffers2 by default
>
> ---
> src/gallium/state_trackers/dri/dri_extensions.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/gallium/state_trackers/dri/dri_extensions.c
> b/src/gallium/state_trackers/dri/dri_extensions.c
> index 1259813..7f8ceef 100644
> --- a/src/gallium/state_trackers/dri/dri_extensions.c
> +++ b/src/gallium/state_trackers/dri/dri_extensions.c
> @@ -99,7 +99,6 @@ static const struct dri_extension card_extensions[] = {
> {"GL_EXT_blend_minmax", GL_EXT_blend_minmax_functions},
> {"GL_EXT_blend_subtract", NULL},
> {"GL_EXT_cull_vertex", GL_EXT_cull_vertex_functions},
> - {"GL_EXT_draw_buffers2", GL_EXT_draw_buffers2_functions},
> {"GL_EXT_fog_coord", GL_EXT_fog_coord_functions},
> {"GL_EXT_framebuffer_object", GL_EXT_framebuffer_object_functions},
> {"GL_EXT_multi_draw_arrays", GL_EXT_multi_draw_arrays_functions},
>
>
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Mesa3d-dev mailing list
> Mesa3d-dev@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
