On Thu, 2010-03-11 at 07:43 -0800, Chia-I Wu wrote:
> On Thu, Mar 11, 2010 at 7:54 PM, Keith Whitwell <kei...@vmware.com> wrote:
> > On Thu, 2010-03-11 at 03:25 -0800, Keith Whitwell wrote:
> >> This is all looking good to me. The code doesn't seem to introduce any
> >> new layering issues or introduce dependencies on existing ones, which
> >> helps with ongoing cleanups.
> >> I did some quick testing with the "linux-debug" target. Gears works,
> >> with and without GALLIUM_WRAP=t. However, demos/singlebuffer seems to
> >> get caught in infinite recursion and segfaults:
> >> Program received signal SIGSEGV, Segmentation fault.
> >> 0x001ab7d5 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:185
> >> 185 {
> >> (gdb) bt
> >> #0 0x001ab7d5 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:185
> >> #1 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> >> #2 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> >> #3 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> >> #4 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> >> #5 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> >> #6 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> >> #7 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> >> #8 0x001ab800 in xmesa_st_framebuffer_flush_front (stfbi=0x80a7d08,
> >> statt=ST_ATTACHMENT_FRONT_LEFT) at xm_st.c:189
> > Also, libgl-xlib / llvmpipe is getting some rendering errors with these
> > patches - seems like culling is messed up maybe. This is with a scons
> > build after adding the missing xm_st.c file.
> > Does it make sense to push these patches to a public Mesa branch so some
> > bugfixing can get done?
> Thanks for testing the patches. I will have a look at the segfault tomorrow.
> I haven't tried llvmpipe. Does softpipe also get the rendering error?
No, purely llvmpipe.
> I will create a topic branch, gallium-st-api, tomorrow and continue the
> development/bugfixing there, unless there are major design defects that should
> be resolved first.
I don't see any major defects - it all looks pretty sensible to me.
Keith
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
