On Mon, Mar 15, 2010 at 5:24 AM, Julien Cristau <jcris...@debian.org> wrote: > On Sat, Mar 13, 2010 at 20:20:36 -0800, Jeff Smith wrote: >> Except that AC_PATH_XTRA returns X_LIBS without '-lX11', while >> PKG_CHECK_MODULES returns X_LIBS with it. In the attached patch >> I add '-lX11' to the former. Of course, with '-lX11' as part of X_LIBS, the >> explicit '-lX11' can be removed from the places that use X_LIBS. >> > If this wants -lX11, then it should use AC_PATH_X, not AC_PATH_XTRA, > though?
AC_PATH_XTRA is just AC_PATH_X with some additional crap to make compiling/linking X programs work on various platforms. I think Jeff is right. I'd forgotten that AC_PATH_X* doesn't actually add the -lX11 to the X_LIBS variable. Jeff, it should get swapped back around to what you had in your patch and a s/X_\(CFLAGS\|LIBS\)/X11_\1/g across the rest of the files. I can put that together a little later if you don't have time to make another patch on master. -- Dan ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
