On Fri, Mar 19, 2010 at 4:17 PM, Xavier Chantry <chantry.xav...@gmail.com> wrote: > On Fri, Mar 19, 2010 at 10:39 PM, Dan Nicholson <dbn.li...@gmail.com> wrote: >> On Fri, Mar 19, 2010 at 2:19 PM, Luca Barbieri <l...@luca-barbieri.com> >> wrote: >>>> Can we just put this program in the demos? Or at least just make it a >>>> separate target (make test-link)? It seems excessive to make this part >>>> of the default build path. >>> >>> The whole purpose is to run this as part of the standard build, so >>> that the build fails if any driver is unloadable, (i.e. a modification >>> to it was botched) and the tree hopefully doesn't get pushed to >>> master. >>> >>> You can test it separately by just running glxinfo/glxgears, obviously. >> >> For developers that makes a lot of sense, but I've never seen any >> other projects impose this type of thing on regular users. >> > > You should only count the projects that allow by default successful > build with undefined symbols (I have honestly no idea how common that > is). > This seems especially bad in mesa where there are many people working > on core parts affecting all drivers and who cannot test easily all the > drivers. At least a build failure to catch the obvious mistakes would > be nice, though that will clearly not solve everything. > > And I think it is as profitable to the user, who do not use / know > about LIBGL_DEBUG=verbose , and won't spot easily the dri failure and > the fallback to software rendering.
I'm OK with this change. If it causes hardship for anyone it could easily be reverted and revisited. -Brian ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
