2010/4/9 Török Edwin <edwinto...@gmail.com>:
> CFLAGS needs to be passed, as you already know.
> Commit 3e17a5b047124c46ee45dbd1848127c67e0d62f3 broke this by adding a new 
> link
> command without CFLAGS.
>
> Signed-off-by: Török Edwin <edwinto...@gmail.com>
> ---
>  src/mesa/drivers/dri/Makefile.template |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/Makefile.template 
> b/src/mesa/drivers/dri/Makefile.template
> index f19cc03..4cdd51e 100644
> --- a/src/mesa/drivers/dri/Makefile.template
> +++ b/src/mesa/drivers/dri/Makefile.template
> @@ -54,7 +54,7 @@ $(LIBNAME): $(OBJECTS) $(MESA_MODULES) $(EXTRA_MODULES) 
> Makefile \
>                $(TOP)/src/mesa/drivers/dri/Makefile.template 
> $(TOP)/src/mesa/drivers/dri/common/dri_test.o
>        $(MKLIB) -o $...@.tmp -noprefix -linker '$(CC)' -ldflags '$(LDFLAGS)' \
>                $(OBJECTS) $(MESA_MODULES) $(EXTRA_MODULES) $(DRI_LIB_DEPS)
> -       $(CC) -o $...@.test $(TOP)/src/mesa/drivers/dri/common/dri_test.o 
> $...@.tmp $(DRI_LIB_DEPS)
> +       $(CC) $(CFLAGS) -o $...@.test 
> $(TOP)/src/mesa/drivers/dri/common/dri_test.o $...@.tmp $(DRI_LIB_DEPS)
>       �...@rm -f $...@.test
>        mv -f $...@.tmp $@
>
> --

Good catch, although it really affects anyone that stores flags
necessary to the linker in CFLAGS. Could you also fix the one in
src/gallium/winsys/drm/Makefile.template from the same commit and
repost the patch? Thanks.

--
Dan

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to