Hi, Backlog from #radeon/freenode (24-Apr-2010, German local-time UTC+2): [...] [11:49:16] <dileX> here I get w/ openaren and mesa (commit 94b04d3d1ccd1b717dbc9d797341f1170121645a) compiled with --debug: state_tracker/st_atom_framebuffer.c:162:update_framebuffer_state: Assertion `framebuffer->zsbuf->texture->bind & (1 << 0)' failed. [11:49:45] <dileX> commit 17249ae8e0e459dea250733a0b3e45036cdb67bd "st/mesa: assert that binding flags are properly set for drawing surfaces" seems to be culprit [11:54:59] <dileX> that works: GALLIUM_ABORT_ON_ASSERT=false openarena [...] [11:59:27] <dileX> Reverting culprit commit lets openarena play with r300g st/dri [...]
- Sedat - P.S.: OpenArena Logs and Revert-patch attached
openarena.log_BROKEN
Description: Binary data
openarena.log_with-reverted-patch
Description: Binary data
From 4d164f8b2bb39d3e87d4f1c9f8ef649ff1fce1a9 Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.di...@gmail.com>
Date: Sat, 24 Apr 2010 11:50:03 +0200
Subject: [PATCH] Revert "st/mesa: assert that binding flags are properly set for drawing surfaces"
This reverts commit 17249ae8e0e459dea250733a0b3e45036cdb67bd.
---
src/mesa/state_tracker/st_atom_framebuffer.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c b/src/mesa/state_tracker/st_atom_framebuffer.c
index 52c507d..1cd5546 100644
--- a/src/mesa/state_tracker/st_atom_framebuffer.c
+++ b/src/mesa/state_tracker/st_atom_framebuffer.c
@@ -153,16 +153,6 @@ update_framebuffer_state( struct st_context *st )
pipe_surface_reference(&framebuffer->zsbuf, NULL);
}
-#ifdef DEBUG
- /* Make sure the resource binding flags were set properly */
- for (i = 0; i < framebuffer->nr_cbufs; i++) {
- assert(framebuffer->cbufs[i]->texture->bind & PIPE_BIND_RENDER_TARGET);
- }
- if (framebuffer->zsbuf) {
- assert(framebuffer->zsbuf->texture->bind & PIPE_BIND_DEPTH_STENCIL);
- }
-#endif
-
cso_set_framebuffer(st->cso_context, framebuffer);
}
--
1.7.0.5
------------------------------------------------------------------------------
_______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
