[
https://issues.apache.org/jira/browse/MESOS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150200#comment-13150200
]
[email protected] commented on MESOS-33:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/
-----------------------------------------------------------
(Updated 2011-11-15 02:29:18.050994)
Review request for mesos, Benjamin Hindman and Andy Konwinski.
Changes
-------
Changed "required string public_hostname" to "required string webui_hostname"
in include/mesos/mesos.proto
Changed "JSON::Object model(const Slave& slave)" in src/master/http.cpp to use
"slave.info.webui_hostname" and swapped the order of the url and port
references
Changed line 273 in src/slave/slave.cpp to use "webui_hostname"
Changed line 278 in src/slave/slave.cpp to eliminate the unnecessary webuiPort
variable by passing the result of "conf.get<int>("webui_port", 8081)" directly
as a parameter to "info.set_webui_port()
Summary
-------
Added webUI field to the SlaveInfo message so that a master can correctly
display hyperlinks to slaves in its webUI.
This addresses bug MESOS-33.
https://issues.apache.org/jira/browse/MESOS-33
Diffs (updated)
-----
include/mesos/mesos.proto 33248ec
src/master/http.cpp 47caf48
src/slave/slave.cpp de5716c
src/webui/master/index.tpl 16e3446
Diff: https://reviews.apache.org/r/2770/diff
Testing
-------
Thanks,
Sumedh
> Fix slave webui representation and pass back to master.
> -------------------------------------------------------
>
> Key: MESOS-33
> URL: https://issues.apache.org/jira/browse/MESOS-33
> Project: Mesos
> Issue Type: Bug
> Components: ec2, master, slave, webui
> Reporter: Benjamin Hindman
> Assignee: Sumedh Sawant
>
> A slave needs to report both it's webui hostname AND it's port back to the
> master so that it can correctly display them in it's own webui.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
