[
https://issues.apache.org/jira/browse/MESOS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155668#comment-13155668
]
[email protected] commented on MESOS-33:
----------------------------------------------------
bq. On 2011-11-14 20:24:47, Benjamin Hindman wrote:
bq. > include/mesos/mesos.proto, line 158
bq. > <https://reviews.apache.org/r/2770/diff/1/?file=56821#file56821line158>
bq. >
bq. > Let's change this to webui_hostname too please.
Done.
bq. On 2011-11-14 20:24:47, Benjamin Hindman wrote:
bq. > src/master/http.cpp, line 114
bq. > <https://reviews.apache.org/r/2770/diff/1/?file=56822#file56822line114>
bq. >
bq. > s/web_ui_url/webui_hostname and swap the order please (and don't
forget to propagate the changes).
Done.
bq. On 2011-11-14 20:24:47, Benjamin Hindman wrote:
bq. > src/slave/slave.cpp, line 273
bq. > <https://reviews.apache.org/r/2770/diff/1/?file=56823#file56823line273>
bq. >
bq. > s/public_hostname/webui_hostname
Done.
- Sumedh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2770/#review3219
-----------------------------------------------------------
On 2011-11-15 02:29:18, Sumedh Sawant wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2770/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-15 02:29:18)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and Andy Konwinski.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added webUI field to the SlaveInfo message so that a master can correctly
display hyperlinks to slaves in its webUI.
bq.
bq.
bq. This addresses bug MESOS-33.
bq. https://issues.apache.org/jira/browse/MESOS-33
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/mesos.proto 33248ec
bq. src/master/http.cpp 47caf48
bq. src/slave/slave.cpp de5716c
bq. src/webui/master/index.tpl 16e3446
bq.
bq. Diff: https://reviews.apache.org/r/2770/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sumedh
bq.
bq.
> Fix slave webui representation and pass back to master.
> -------------------------------------------------------
>
> Key: MESOS-33
> URL: https://issues.apache.org/jira/browse/MESOS-33
> Project: Mesos
> Issue Type: Bug
> Components: ec2, master, slave, webui
> Reporter: Benjamin Hindman
> Assignee: Sumedh Sawant
>
> A slave needs to report both it's webui hostname AND it's port back to the
> master so that it can correctly display them in it's own webui.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
