----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2990/#review3915 -----------------------------------------------------------
Ship it! Minor nits, but clean it up and let's ship it! On to the next step! src/slave/constants.hpp <https://reviews.apache.org/r/2990/#comment8801> Just put a todo at the top of the file that says: "Make these constants configurable." src/slave/http.cpp <https://reviews.apache.org/r/2990/#comment8802> Indentation? src/slave/http.cpp <https://reviews.apache.org/r/2990/#comment8803> Indentation? src/webui/slave/index.tpl <https://reviews.apache.org/r/2990/#comment8804> Move the % back to the beginning of the line. src/webui/slave/index.tpl <https://reviews.apache.org/r/2990/#comment8805> Here too. - Benjamin On 2011-12-05 23:52:29, Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2990/ > ----------------------------------------------------------- > > (Updated 2011-12-05 23:52:29) > > > Review request for mesos, Benjamin Hindman and Andy Konwinski. > > > Summary > ------- > > Added a framework history to the slave page, an executor history to the > framework page, and a task history to the executor page. Allows stdout and > stderr of executors to be viewed after they finish executing. > > > This addresses bug MESOS-8. > https://issues.apache.org/jira/browse/MESOS-8 > > > Diffs > ----- > > src/slave/constants.hpp 489640b > src/slave/http.cpp 18efd8c > src/slave/slave.hpp 37bbd8c > src/slave/slave.cpp 665ab7f > src/webui/slave/executor.tpl dd53464 > src/webui/slave/framework.tpl 9488da5 > src/webui/slave/index.tpl 0f18de6 > > Diff: https://reviews.apache.org/r/2990/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
